Interface's methods should not return concrete class#23
Open
FrantzUml wants to merge 1 commit intolaminas:2.13.xfrom
Open
Interface's methods should not return concrete class#23FrantzUml wants to merge 1 commit intolaminas:2.13.xfrom
FrantzUml wants to merge 1 commit intolaminas:2.13.xfrom
Conversation
Changed the return type to 'static' for PhpDocs. A minima 'UriInterface' if you do not want static Signed-off-by: FrantzUml <[email protected]>
Ocramius
approved these changes
Oct 3, 2024
Member
Ocramius
left a comment
Ocramius
left a comment
There was a problem hiding this comment.
From my PoV, this is valid.
WDYT, @froschdesign?
Member
|
Makes sense to me. But the concrete implementation of this component must also be modified: Lines 37 to 40 in 95a41a7 |
Member
|
@FrantzUml any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the return type to 'static' for PhpDocs.
A minima 'UriInterface' if you do not want static